git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] gitweb: Return or exit after done serving request

From
Junio C Hamano <gitster@pobox.com>
Date
Jun 14, 2010, 20:54 UTC
Message-ID
<7v8w6h9vy2.fsf@alter.siamese.dyndns.org>
In-Reply-To
<201006141029.00310.jnareb@gmail.com>
Jakub Narebski <jnareb@gmail.com> writes:
Show 13 quoted lines
> On Mon, 14 June 2010, Junio C Hamano wrote:
> ...
>> Is the last "1;" still needed if we did this?
>
> Probably not, and probably we never need this.
>> 
>> I am guessing that this new codeblock will go inside "sub run" when
>> merging with your c2394fe (gitweb: Put all per-connection code in run()
>> subroutine, 2010-05-07) and Sam's a0446e7 (gitweb: Add support for
>> FastCGI, using CGI::Fast, 2010-05-07).  If I am mistaken, please advise.
>
> No, the code is meant to be after last code to be run in gitweb, 
> in *top level* scope, otherwise it would always return.

Ok, tentatively I fixed the mismerge of 'pu' from the last night and pushed it out.

Previous: Jakub Narebski
Message 4 of 4 in “gitweb: Return or exit after done serving request”
  1. gitweb: Return or exit after done serving requestJakub Narebski, Jun 13, 2010
  2. Junio C HamanoJun 14, 2010
  3. Jakub NarebskiJun 14, 2010
  4. Junio C HamanoJun 14, 2010

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.