From: Junio C Hamano <gitster@pobox.com>
Date: Mon, 14 Jun 2010 20:54:29 GMT
Subject: Re: [PATCH] gitweb: Return or exit after done serving request
Message-ID: <7v8w6h9vy2.fsf@alter.siamese.dyndns.org>
In-Reply-To: <201006141029.00310.jnareb@gmail.com>

Jakub Narebski <jnareb@gmail.com> writes:

> On Mon, 14 June 2010, Junio C Hamano wrote:
> ...
>> Is the last "1;" still needed if we did this?
>
> Probably not, and probably we never need this.
>> 
>> I am guessing that this new codeblock will go inside "sub run" when
>> merging with your c2394fe (gitweb: Put all per-connection code in run()
>> subroutine, 2010-05-07) and Sam's a0446e7 (gitweb: Add support for
>> FastCGI, using CGI::Fast, 2010-05-07).  If I am mistaken, please advise.
>
> No, the code is meant to be after last code to be run in gitweb, 
> in *top level* scope, otherwise it would always return.

Ok, tentatively I fixed the mismerge of 'pu' from the last night and
pushed it out.