Re: [PATCH v3 1/3] Add setup_merge_commit function to merge/builtin.c.

Jared Hance <jaredhance@gmail.com> writes:

> Subject: Re: [PATCH v3 1/3] Add setup_merge_commit function to merge/builtin.c.

Please spell the name of the file you are touching correctly ;-).

	Subject: builtin/merge.c: Add setup_merge_commit function

> Adds a new function that will be used in a later patch as well as the
> current code to reduce redundancy.

Redandunt.  If you say "add", we know the function is "new" ;-)

State what that function does instead of a vague "reduce redundancy", perhaps like...

	Refactor the loop to parse list of commits given from the command
        line into a separate helper function.

The patch itself looks good.

Thanks.