git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH/RFC] gitweb: Fix actionless dispatch for non-existent objects

From
Junio C Hamano <gitster@pobox.com>
Date
Jan 9, 2012, 21:30 UTC
Message-ID
<7v8vlgef7o.fsf@alter.siamese.dyndns.org>
In-Reply-To
<20120107104552.26867.41282.stgit@localhost.localdomain>
Jakub Narebski <jnareb@gmail.com> writes:
Show 8 quoted lines
> When gitweb URL does not provide action explicitly, e.g.
>
>   http://git.example.org/repo.git/branch
>
> dispatch() tries to guess action (view to be used) based on remaining
> parameters.  Among others it is based on the type of requested object,
> which gave problems when asking for non-existent branch or file (for
> example misspelt name).

Ok. "gave problems" is a bit unclear to see why explicitly calling die_error() is an improvement, though. What is the nature of the "problems"? Giving a server error 500 because later codepaths tried to call an undefined subroutine?

> Now undefined $action from dispatch() should not result in problems.

Again, unspecified "problems" here. I'd like this sentence to end with "should not result in X but gives an explicit '404 not found' error".

Thanks.
Previous: Jakub NarebskiNext: Jakub Narebski
Message 2 of 3 in “gitweb: Fix actionless dispatch for non-existent objects”
  1. gitweb: Fix actionless dispatch for non-existent objectsJakub Narebski, Jan 7, 2012
  2. Junio C HamanoJan 9, 2012
  3. Jakub NarebskiJan 9, 2012

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.