From: Junio C Hamano <gitster@pobox.com>
Date: Mon, 09 Jan 2012 21:30:35 GMT
Subject: Re: [PATCH/RFC] gitweb: Fix actionless dispatch for non-existent objects
Message-ID: <7v8vlgef7o.fsf@alter.siamese.dyndns.org>
In-Reply-To: <20120107104552.26867.41282.stgit@localhost.localdomain>

Jakub Narebski <jnareb@gmail.com> writes:

> When gitweb URL does not provide action explicitly, e.g.
>
>   http://git.example.org/repo.git/branch
>
> dispatch() tries to guess action (view to be used) based on remaining
> parameters.  Among others it is based on the type of requested object,
> which gave problems when asking for non-existent branch or file (for
> example misspelt name).

Ok. "gave problems" is a bit unclear to see why explicitly calling
die_error() is an improvement, though. What is the nature of the
"problems"? Giving a server error 500 because later codepaths tried to
call an undefined subroutine?

> Now undefined $action from dispatch() should not result in problems.

Again, unspecified "problems" here. I'd like this sentence to end with
"should not result in X but gives an explicit '404 not found' error".

Thanks.