git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] t/Makefile: Use $(sort ...) explicitly where needed

From
Junio C Hamano <gitster@pobox.com>
Date
Jan 19, 2012, 22:01 UTC
Message-ID
<7v8vl3ic6o.fsf@alter.siamese.dyndns.org>
In-Reply-To
<1327004244-18892-1-git-send-email-kirr@navytux.spb.ru>
Kirill Smelkov <kirr@navytux.spb.ru> writes:
Show 13 quoted lines
> Starting from GNU Make 3.82 $(wildcard ...) no longer sorts the result
> (from NEWS):
>
>     * WARNING: Backward-incompatibility!
>       Wildcards were not documented as returning sorted values, but the results
>       have been sorted up until this release..  If your makefiles require sorted
>       results from wildcard expansions, use the $(sort ...)  function to request
>       it explicitly.
>
>     http://repo.or.cz/w/make.git/commitdiff/2a59dc32aaf0681dec569f32a9d7ab88a379d34f
>
> so we have to sort tests list or else they are executed in seemingly
> random order even for -j1.
I do not necessarily buy your "so we HAVE TO, OR ELSE".

Even though I can understand "We can sort the list of tests _if_ we do not want them executed in seemingly random order when running 'make -j1'", I tend to think that *if* is a big one. Aren't these tests designed not to depend on each other anyway?

Previous: Kirill SmelkovNext: Kirill Smelkov
Message 2 of 6 in “t/Makefile: Use $(sort ...) explicitly where needed”
  1. t/Makefile: Use $(sort ...) explicitly where neededKirill Smelkov, Jan 19, 2012
  2. Junio C HamanoJan 19, 2012
  3. Kirill SmelkovJan 20, 2012
  4. Junio C HamanoJan 20, 2012
  5. Kirill SmelkovJan 20, 2012
  6. Kirill SmelkovJan 22, 2012

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.