[PATCH] t/Makefile: Use $(sort ...) explicitly where needed
- From
Kirill Smelkov <kirr@navytux.spb.ru>
- Date
- Jan 19, 2012, 20:17 UTC
- Message-ID
- <1327004244-18892-1-git-send-email-kirr@navytux.spb.ru>
Starting from GNU Make 3.82 $(wildcard ...) no longer sorts the result (from NEWS):
* WARNING: Backward-incompatibility!
Wildcards were not documented as returning sorted values, but the results
have been sorted up until this release.. If your makefiles require sorted
results from wildcard expansions, use the $(sort ...) function to request
it explicitly.http://repo.or.cz/w/make.git/commitdiff/2a59dc32aaf0681dec569f32a9d7ab88a379d34f
so we have to sort tests list or else they are executed in seemingly random order even for -j1.
Signed-off-by: Kirill Smelkov <kirr@navytux.spb.ru> --- t/Makefile | 6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/t/Makefile b/t/Makefile index 9046ec9..66ceefe 100644 --- a/t/Makefile +++ b/t/Makefile @@ -17,9 +17,9 @@ DEFAULT_TEST_TARGET ?= test # Shell quote; SHELL_PATH_SQ = $(subst ','\'',$(SHELL_PATH)) -T = $(wildcard t[0-9][0-9][0-9][0-9]-*.sh) -TSVN = $(wildcard t91[0-9][0-9]-*.sh) -TGITWEB = $(wildcard t95[0-9][0-9]-*.sh) +T = $(sort $(wildcard t[0-9][0-9][0-9][0-9]-*.sh)) +TSVN = $(sort $(wildcard t91[0-9][0-9]-*.sh)) +TGITWEB = $(sort $(wildcard t95[0-9][0-9]-*.sh)) all: $(DEFAULT_TEST_TARGET)
-- 1.7.9.rc2.124.ge3180