git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH] t/Makefile: Use $(sort ...) explicitly where needed

From
Kirill Smelkov <kirr@navytux.spb.ru>
Date
Jan 19, 2012, 20:17 UTC
Message-ID
<1327004244-18892-1-git-send-email-kirr@navytux.spb.ru>

Starting from GNU Make 3.82 $(wildcard ...) no longer sorts the result (from NEWS):

    * WARNING: Backward-incompatibility!
      Wildcards were not documented as returning sorted values, but the results
      have been sorted up until this release..  If your makefiles require sorted
      results from wildcard expansions, use the $(sort ...)  function to request
      it explicitly.
    http://repo.or.cz/w/make.git/commitdiff/2a59dc32aaf0681dec569f32a9d7ab88a379d34f

so we have to sort tests list or else they are executed in seemingly random order even for -j1.

Signed-off-by: Kirill Smelkov <kirr@navytux.spb.ru>
---
 t/Makefile |    6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/t/Makefile b/t/Makefile
index 9046ec9..66ceefe 100644
--- a/t/Makefile
+++ b/t/Makefile
@@ -17,9 +17,9 @@ DEFAULT_TEST_TARGET ?= test
 # Shell quote;
 SHELL_PATH_SQ = $(subst ','\'',$(SHELL_PATH))
 
-T = $(wildcard t[0-9][0-9][0-9][0-9]-*.sh)
-TSVN = $(wildcard t91[0-9][0-9]-*.sh)
-TGITWEB = $(wildcard t95[0-9][0-9]-*.sh)
+T = $(sort $(wildcard t[0-9][0-9][0-9][0-9]-*.sh))
+TSVN = $(sort $(wildcard t91[0-9][0-9]-*.sh))
+TGITWEB = $(sort $(wildcard t95[0-9][0-9]-*.sh))
 
 all: $(DEFAULT_TEST_TARGET)
 
-- 
1.7.9.rc2.124.ge3180
Next: Junio C Hamano
Message 1 of 6 in “t/Makefile: Use $(sort ...) explicitly where needed”
  1. t/Makefile: Use $(sort ...) explicitly where neededKirill Smelkov, Jan 19, 2012
  2. Junio C HamanoJan 19, 2012
  3. Kirill SmelkovJan 20, 2012
  4. Junio C HamanoJan 20, 2012
  5. Kirill SmelkovJan 20, 2012
  6. Kirill SmelkovJan 22, 2012

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.