git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 8/9 v13] difftool: teach difftool to handle directory diffs

From
Junio C Hamano <gitster@pobox.com>
Date
Apr 18, 2012, 19:38 UTC
Message-ID
<7v8vhsltk3.fsf@alter.siamese.dyndns.org>
In-Reply-To
<CAFouetgWpyUC9SPo_QwpESrbfib7ct111WesKPP14HQ+SqpFaQ@mail.gmail.com>
Tim Henigan <tim.henigan@gmail.com> writes:
Show 6 quoted lines
> Looking back on it now, I agree that it would have been better to use
> the plumbing commands from the beginning.  Changing from the porcelain
> to the plumbing commands will require new logic to parse the diff
> options to figure out which of 'diff-index', 'diff-files' or
> 'diff-tree' should be called.  We may also want to add support for
> some specific standard diff options (like '-R').

Yeah, didn't I already suggest that it is the only sane avenue in the long term to move the whole "populate the two temporary trees" thing down to C level?

> For now, would you object to an updated patch that simply detects and
> ignores options that change the output of 'git diff --raw'?

As a script that uses 'git diff' is a short-term hack anyway, I think the most cost effective thing to do is to add '--no-renames' at the end and be done with it.

Previous: Tim HeniganNext: Tim Henigan
Message 10 of 14 in “difftool: teach difftool to handle directory diffs”
  1. 8/9 difftool: teach difftool to handle directory diffsTim Henigan, Apr 13, 2012
  2. David AguilarApr 15, 2012
  3. David AguilarApr 16, 2012
  4. David AguilarApr 16, 2012
  5. Tim HeniganApr 17, 2012
  6. David AguilarApr 18, 2012
  7. Tim HeniganApr 18, 2012
  8. Junio C HamanoApr 18, 2012
  9. Tim HeniganApr 18, 2012
  10. Junio C HamanoApr 18, 2012
  11. Tim HeniganApr 19, 2012
  12. Junio C HamanoApr 19, 2012
  13. David AguilarApr 20, 2012
  14. Tim HeniganApr 20, 2012

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.