From: Junio C Hamano Date: Wed, 18 Apr 2012 19:38:04 GMT Subject: Re: [PATCH 8/9 v13] difftool: teach difftool to handle directory diffs Message-ID: <7v8vhsltk3.fsf@alter.siamese.dyndns.org> In-Reply-To: Tim Henigan writes: > Looking back on it now, I agree that it would have been better to use > the plumbing commands from the beginning. Changing from the porcelain > to the plumbing commands will require new logic to parse the diff > options to figure out which of 'diff-index', 'diff-files' or > 'diff-tree' should be called. We may also want to add support for > some specific standard diff options (like '-R'). Yeah, didn't I already suggest that it is the only sane avenue in the long term to move the whole "populate the two temporary trees" thing down to C level? > For now, would you object to an updated patch that simply detects and > ignores options that change the output of 'git diff --raw'? As a script that uses 'git diff' is a short-term hack anyway, I think the most cost effective thing to do is to add '--no-renames' at the end and be done with it.