Re: [PATCH] git-grep: --and to combine patterns with and instead of or

From: Junio C Hamano <junkio@cox.net>
Date: Jun 30, 2006, 04:13 UTC
Message-ID: <7v7j2zmgbu.fsf@assigned-by-dhcp.cox.net>
In-Reply-To: <E1Fw8hS-00023y-FY@moooo.ath.cx>

Matthias Lederhofer <matled@gmx.net> writes:

Show 9 quoted lines

> OR and AND have precedence, so there are two possibilities, I'd take
> the first one.
> 1. OR, AND:
>     This will make it easier to read because OR can be skipped:
>       pat1 pat2 AND pat3 pat4
>     = pat1 OR pat2 AND pat3 OR pat4
>     = (pat1 OR pat2) AND (pat3 OR pat4)
> 2. AND, OR:
>     This is a bit more logic if you think of AND as * and OR as +.

> ... FOO should not be named --and imo but I don't have any idea
> for a good name atm.

I personally feel FOO should not even exist. An option that covers the entire expression to make operator precedence in it sounds quite evil.

I would say make --and bind tighter than --or and use parentheses as needed. Making --or optional sounds fine as that would make the default "multiple -e" case similar to what GNU grep does without any --and nor --or.