Re: [PATCH] git-grep: --and to combine patterns with and instead of or

From: Junio C Hamano <junkio@cox.net>
Date: Jun 30, 2006, 07:56 UTC
Message-ID: <7v3bdnkrfb.fsf@assigned-by-dhcp.cox.net>
In-Reply-To: <E1FwDiI-0007Xp-2s@moooo.ath.cx>

Matthias Lederhofer <matled@gmx.net> writes:

> (Junio: please reply to this one, forgot the Cc in the first one :/)

Huh?

Show 9 quoted lines

>> I personally feel FOO should not even exist.  An option that
>> covers the entire expression to make operator precedence in it
>> sounds quite evil.  
>> 
>> I would say make --and bind tighter than --or and use parentheses as
>> needed.
> Ok, perhaps changing operator precedence is a bit much. What do you
> think of that then:
> ...

I see you are trying hard to think of a way to justify your original prefix "--and" (or --FOO) implementation, but I simply do not see much point in that. I doubt changing the default operator from --or to --and is less confusing than changing the precedence for the users, so you would hear the same "I personally feel FOO should not even exist" objection from me.