Re: [PATCH (3rd try)] Add git-stash script

From: Junio C Hamano <gitster@pobox.com>
Date: Jun 30, 2007, 06:25 UTC
Message-ID: <7v7ipmdkme.fsf@assigned-by-dhcp.pobox.com>
In-Reply-To: <20070630061237.GA14344@coredump.intra.peff.net>

Jeff King <peff@peff.net> writes:

Show 14 quoted lines

> On Sat, Jun 30, 2007 at 02:37:09PM +0900, しらいしななこ wrote:
>
>> +ref_stash=refs/stash
> [...]
>> +save_stash () {
>> +	if no_changes
>> +	then
>> +		echo >&2 'No local changes to save'
>> +		exit 0
>> +	fi
>> +	test -f "$GIT_DIR/logs/refs/stash" ||
>> +		clear_stash || die "Cannot initialize stash"
>
> Nit: this should be .../logs/$ref_stash

Sharp eyes.

I'll take a look and possibly comment on it later, but from a cursory look I do not see major problems, so if I decide to apply it I'll try to remember fixing this up when I do so...