Re: [PATCH] Document git-stash

From: Jeff King <peff@peff.net>
Date: Jul 1, 2007, 09:19 UTC
Message-ID: <20070701091905.GA13559@coredump.intra.peff.net>
In-Reply-To: <200707010910.l619A23c027837@mi0.bluebottle.com>

On Sun, Jul 01, 2007 at 06:06:29PM +0900, しらいしななこ wrote:

> I don't understand myself anymore, either (^_^;) I just tried to follow
> Jnio's earlier suggestion in his message.  He said this.

OK, we will wait for Junio to clarify tomorrow. :)

Show 9 quoted lines

> >> +	Removes all the stashed states.
> >
> > Maybe a note to indicate that this can lose data? Something like:
> >
> >   ...stashed states. Note that those states will then be subject to
> >   pruning, and may be difficult or impossible to recover.
> 
> I see.  When I wrote it, I thought that saying "removes" was enough.  It
> seemed obvious to me that you would lose it when you remove it.

It is "enough" in the sense that the meaning is clear, but in general it is very hard to convince git to forget things, and I think that is a feature. There are so few commands in git where you can "lose" data that I think it is worth marking them with a big X.

Really, I don't see the need to use 'clear' in general. The reflog works as a stack, so old stashes will get out of the "top 10" eventually anyway. In the long run, they will be cleaned up by "git reflog expire" (or indirectly by "git gc").

> Thanks for fixing my language.  I am not very good at writing English,
> but you probably have already found it out (^_^;).

Quite the contrary. If it had been very badly written, it would have just been easier to rewrite it than to point out the few mistakes. :)

-Peff