git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] Move worktree setup out of setup_git_directory*

From
Junio C Hamano <gitster@pobox.com>
Date
Feb 25, 2008, 19:01 UTC
Message-ID
<7v7igskgi3.fsf@gitster.siamese.dyndns.org>
In-Reply-To
<fcaeb9bf0802250517x2192b51epf2a162b0a984e99c@mail.gmail.com>
"Nguyen Thai Ngoc Duy" <pclouds@gmail.com> writes:
Show 6 quoted lines
> Interesting. It currently does chdir(). But it is pointless now as
> worktree should not be accessed until setup_work_tree() is called.
> setup_git_directory* should not return a prefix at all.
> ...
> I guess I just need to verify your statements and put them to
> Doc/technical/api-setup.txt ;)

The above, as I said, was written out of thin air without re-reading the current code nor carefully reading what your patch does, so I am afraid there needs a lot more than that to happen before we have something to validate the callers against, but I think you got why I think it is a good idea to have that documented.

Previous: Nguyen Thai Ngoc Duy
Message 4 of 4 in “Move worktree setup out of setup_git_directory*”
  1. Move worktree setup out of setup_git_directory*Nguyễn Thái Ngọc Duy, Feb 24, 2008
  2. Junio C HamanoFeb 25, 2008
  3. Nguyen Thai Ngoc DuyFeb 25, 2008
  4. Junio C HamanoFeb 25, 2008

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.