From: Junio C Hamano <gitster@pobox.com>
Date: Mon, 25 Feb 2008 19:01:08 GMT
Subject: Re: [PATCH] Move worktree setup out of setup_git_directory*
Message-ID: <7v7igskgi3.fsf@gitster.siamese.dyndns.org>
In-Reply-To: <fcaeb9bf0802250517x2192b51epf2a162b0a984e99c@mail.gmail.com>

"Nguyen Thai Ngoc Duy" <pclouds@gmail.com> writes:

> Interesting. It currently does chdir(). But it is pointless now as
> worktree should not be accessed until setup_work_tree() is called.
> setup_git_directory* should not return a prefix at all.
> ...
> I guess I just need to verify your statements and put them to
> Doc/technical/api-setup.txt ;)

The above, as I said, was written out of thin air without
re-reading the current code nor carefully reading what your
patch does, so I am afraid there needs a lot more than that
to happen before we have something to validate the callers
against, but I think you got why I think it is a good idea to
have that documented.