git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 0/3] fix "diff --raw" on the work tree side

From
Junio C Hamano <gitster@pobox.com>
Date
Mar 2, 2008, 17:11 UTC
Message-ID
<7v7igloxtu.fsf@gitster.siamese.dyndns.org>
In-Reply-To
<46dff0320803020241l29277bd4m1a711ff0a863e7f8@mail.gmail.com>
"Ping Yin" <pkufranky@gmail.com> writes:
Show 10 quoted lines
> On Sun, Mar 2, 2008 at 5:43 PM, Junio C Hamano <gitster@pobox.com> wrote:
>> The second patch fixes the inconsistency between "git-diff --raw" and
>>  "git-diff-{index,files} --raw" when they are used for submodules.
>>
>>  The third one is a bit controversial and changes the semantics and
>>  existing callers and won't be considered for 1.5.5.
>>
> Unfortunately, my submodule summary patch series will depend on
> git-diff or git-diff-index. So should i resend my improved patch only
> after the thrid one is applied?

I do not think re-introducing the inconsistency like the third one does is a palatable option.

Wouldn't grabbing (cd $submodule && git rev-parse HEAD) yourself be more portable across git before and after the bugfix of "git diff --raw"?

Previous: Ping YinNext: Ping Yin
Message 6 of 8 in “fix "diff --raw" on the work tree side”
  1. 0/3 fix "diff --raw" on the work tree sideJunio C Hamano, Mar 2, 2008
  2. 1/3 diff-lib.c: constness strengtheningJunio C Hamano, Mar 2, 2008
  3. 2/3 diff: make sure work tree side is shown as 0{40} when differentJunio C Hamano, Mar 2, 2008
  4. 3/3 diff: show submodule object name when available even on the work tree sideJunio C Hamano, Mar 2, 2008
  5. Ping YinMar 2, 2008
  6. Junio C HamanoMar 2, 2008
  7. Ping YinMar 2, 2008
  8. Junio C HamanoMar 2, 2008

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.