From: Junio C Hamano <gitster@pobox.com>
Date: Sun, 02 Mar 2008 17:11:25 GMT
Subject: Re: [PATCH 0/3] fix "diff --raw" on the work tree side
Message-ID: <7v7igloxtu.fsf@gitster.siamese.dyndns.org>
In-Reply-To: <46dff0320803020241l29277bd4m1a711ff0a863e7f8@mail.gmail.com>

"Ping Yin" <pkufranky@gmail.com> writes:

> On Sun, Mar 2, 2008 at 5:43 PM, Junio C Hamano <gitster@pobox.com> wrote:
>> The second patch fixes the inconsistency between "git-diff --raw" and
>>  "git-diff-{index,files} --raw" when they are used for submodules.
>>
>>  The third one is a bit controversial and changes the semantics and
>>  existing callers and won't be considered for 1.5.5.
>>
> Unfortunately, my submodule summary patch series will depend on
> git-diff or git-diff-index. So should i resend my improved patch only
> after the thrid one is applied?

I do not think re-introducing the inconsistency like the third one does is
a palatable option.

Wouldn't grabbing (cd $submodule && git rev-parse HEAD) yourself be more
portable across git before and after the bugfix of "git diff --raw"?