git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] perl/Makefile: handle paths with spaces in the NO_PERL_MAKEMAKER section

From
Junio C Hamano <gitster@pobox.com>
Date
Aug 6, 2008, 15:33 UTC
Message-ID
<7v7iaurwe4.fsf@gitster.siamese.dyndns.org>
In-Reply-To
<klGWkbWGpsUHZpuNwl9WvZs5UGGfYVAngWbiM3eippaejrXLNyLpRA@cipher.nrlssc.navy.mil>
Brandon Casey <casey@nrlssc.navy.mil> writes:
Show 14 quoted lines
> Junio C Hamano wrote:
>> Brandon Casey <casey@nrlssc.navy.mil> writes:
>> 
>>> Use double quotes to protect against paths which may contain spaces.
>>> ...
>>> +	echo '	mkdir -p "$(instdir_SQ)"' >> $@
>> 
>> Is this sufficient?  We seem to apply double-sq when writing shell
>> scriptlet in GIT-BUILD-OPTIONS from the main Makefile, and I suspect you
>> would need to do something similar.
>
> It seems to be sufficient. The double quotes survived into my perl.mak file
> and the two perl modules were installed correctly when I supplied a prefix
> with spaces. Is there something else to be concerned about?

I think the generic way GIT-BUILD-OPTIONS writing is done covers cases where the installation directory has funnies other than whitespace, e.g. double quotes. Is your 'echo "$(instdir_SQ)"' sufficient?

Previous: Brandon CaseyNext: Brandon Casey
Message 4 of 10 in “perl/Makefile: handle paths with spaces in the NO_PERL_MAKEMAKER section”
  1. perl/Makefile: handle paths with spaces in the NO_PERL_MAKEMAKER sectionBrandon Casey, Aug 5, 2008
  2. Junio C HamanoAug 5, 2008
  3. Brandon CaseyAug 6, 2008
  4. Junio C HamanoAug 6, 2008
  5. Brandon CaseyAug 6, 2008
  6. Junio C HamanoAug 6, 2008
  7. perl/Makefile: handle paths with spaces by adding additional quotingBrandon Casey, Aug 6, 2008
  8. Brandon CaseyAug 6, 2008
  9. Brandon CaseyAug 7, 2008
  10. perl/Makefile: make NO_PERL_MAKEMAKER section more robustBrandon Casey, Aug 6, 2008

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.