git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] perl/Makefile: handle paths with spaces in the NO_PERL_MAKEMAKER section

From
Brandon Casey <casey@nrlssc.navy.mil>
Date
Aug 6, 2008, 22:16 UTC
Message-ID
<1JOFfIWYHgmUErPhpB6xWtV5uZYv3_v3tBnt928x644O-1AquEzzIA@cipher.nrlssc.navy.mil>
In-Reply-To
<7vy739nbmp.fsf@gitster.siamese.dyndns.org>
Junio C Hamano wrote:
Show 8 quoted lines
> Brandon Casey <casey@nrlssc.navy.mil> writes:
> 
>> There are problems here with spaces, single quotes, and double quotes.
>> I'll follow up in another email.
> 
> I guess we've opened up a large can of worms.  Let's have the minimum fix
> that says "We do support whitespace in these paths but no other funnies"
> and leave the more intrusive one for post 1.6.0, for now.
I think those two patches I just sent are enough.

You can apply the double-quote escaping patch I sent earlier if you want (the one that escapes double quotes in the macros compiled in c programs). But we'd have a problem installing the perl scripts using MakeMaker, and we'd have a problem _running_ the perl scripts since the single double quote causes a syntax error in the perl script. Let's wait till someone wants to have " in their path shows up (and let them figure out how to fix it).

-brandon
Previous: Brandon CaseyNext: Brandon Casey
Message 8 of 10 in “perl/Makefile: handle paths with spaces in the NO_PERL_MAKEMAKER section”
  1. perl/Makefile: handle paths with spaces in the NO_PERL_MAKEMAKER sectionBrandon Casey, Aug 5, 2008
  2. Junio C HamanoAug 5, 2008
  3. Brandon CaseyAug 6, 2008
  4. Junio C HamanoAug 6, 2008
  5. Brandon CaseyAug 6, 2008
  6. Junio C HamanoAug 6, 2008
  7. perl/Makefile: handle paths with spaces by adding additional quotingBrandon Casey, Aug 6, 2008
  8. Brandon CaseyAug 6, 2008
  9. Brandon CaseyAug 7, 2008
  10. perl/Makefile: make NO_PERL_MAKEMAKER section more robustBrandon Casey, Aug 6, 2008

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.