Re: [PATCH] Add --filedirstat diff option

From: Junio C Hamano <gitster@pobox.com>
Date: Sep 3, 2008, 00:44 UTC
Message-ID: <7v7i9udpmg.fsf@gitster.siamese.dyndns.org>
In-Reply-To: <20080903001254.GA12263@coredump.intra.peff.net>

Jeff King <peff@peff.net> writes:

Show 22 quoted lines

> On Tue, Sep 02, 2008 at 04:55:39PM -0700, Junio C Hamano wrote:
>
>> "filedirstat" is simply too long to type, and it has a certain "Huh?"
>> factor --- is it about file, or is it about directory?
>
> I had the same thought when I saw the original patch...
>
>> This option essentially is just the dirstat but with different logic to
>> compute how big the damage is.  Conceptually, the original one gives one
>> "damage point" to each added or deleted line.
>> 
>>         $ git show --dirstat=<one-point-per-line>
>
> ...and I thought of --dirstat-byfile. So maybe:
>
>   --dirstat=byfile
>
> and
>
>   --dirstat=byline
>
> defaulting to byline (or by-line if preferred).

As Heikki points out (and I missed this initially myself), --dirstat[=x] already exists and it gives the cut-off-point.

Perhaps "--dirstat-by-file" that implies "--dirstat" (with the understanding (and documentation) that "--dirstat" is a shorthand for "--dirstat-by-line" that does not exist)?