git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] Add --filedirstat diff option

From
HOHeikki Orsila <shd@modeemi.fi>
Date
Sep 3, 2008, 00:08 UTC
Message-ID
<20080903000827.GB1252@jolt.modeemi.cs.tut.fi>
In-Reply-To
<7v3akigl1g.fsf@gitster.siamese.dyndns.org>
On Tue, Sep 02, 2008 at 04:55:39PM -0700, Junio C Hamano wrote:
Show 26 quoted lines
> realized that I forgot to mention one thing.
> 
> The name.
> 
> "filedirstat" is simply too long to type, and it has a certain "Huh?"
> factor --- is it about file, or is it about directory?
> 
> This option essentially is just the dirstat but with different logic to
> compute how big the damage is.  Conceptually, the original one gives one
> "damage point" to each added or deleted line.
> 
>         $ git show --dirstat=<one-point-per-line>
> 
> and yours awards one point to each file, whatever the size of the damage
> is.
> 
>         $ git show --dirstat=<one-point-per-file>
> 
> I cannot come up with a short-and-sweet name for one-point-per-X offhand,
> but expressing this variant as an option to --dirstat will leave the door
> open for other people to come up with different system to award damage
> points.  Perhaps
> 
> 	$ git show --dirstat=exclude-typofixes
> 
> might even be not just interesting but useful ;-)

I wouldn't add new semantics for --dirstat=x since it's easy to add new options. We already have --cumulative, so adding options is not new. How about "--dirstat --filemode"? It's long, but it is obvious. I don't think length is relevant here. A shorter but obscure syntax would be "--dirstat2" :-)

-- 
Heikki Orsila
heikki.orsila@iki.fi
http://www.iki.fi/shd
Previous: Junio C HamanoNext: Junio C Hamano
Message 6 of 12 in “Add --filedirstat diff option”
  1. Add --filedirstat diff optionHeikki Orsila, Sep 1, 2008
  2. Junio C HamanoSep 2, 2008
  3. Heikki OrsilaSep 2, 2008
  4. Junio C HamanoSep 2, 2008
  5. Junio C HamanoSep 2, 2008
  6. Heikki OrsilaSep 3, 2008
  7. Re* [PATCH] Add --filedirstat diff optionJunio C Hamano, Sep 3, 2008
  8. Heikki OrsilaSep 3, 2008
  9. Jeff KingSep 3, 2008
  10. Heikki OrsilaSep 3, 2008
  11. Junio C HamanoSep 3, 2008
  12. Jeff KingSep 3, 2008

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.