Re: [PATCH] commit -c/-C/--amend: take over authorship and restamp time with --claim

From: Junio C Hamano <gitster@pobox.com>
Date: Oct 31, 2009, 21:24 UTC
Message-ID: <7v7hub5kam.fsf@alter.siamese.dyndns.org>
In-Reply-To: <1256958480-6775-1-git-send-email-erick.mattos@gmail.com>

Erick Mattos <erick.mattos@gmail.com> writes:

> The new --claim option is meant to solve this need by regenerating the
> timestamp and setting as new author the committer or the one specified
> on --author option.

I'll leave discussion on the option name to others.

> +--claim::
> +	When used with -C/-c/--amend options the committer takes over
> +	the cloned commit authorship and renew the timestamp thus using
> +	only the commit message from the source.

"The cloned commit" is a bit misleading; in the mind of users --amend does not clone but rewrite, as the old commit usually only belongs to a reflog and not any other branch. I'd rewrite it this way, perhaps.

	When used with -C/-c/--amend options, declare that the authorship
	of the resulting commit now belongs of the committer.  This also
	renews the author timestamp.

We also would need a test to protect this new feature from getting broken by future updates.

Thanks.