Re: [PATCH] commit -c/-C/--amend: acquire authorship and restamp time with --claim

From: Erick Mattos <erick.mattos@gmail.com>
Date: Nov 2, 2009, 00:54 UTC
Message-ID: <55bacdd30911011654k22eb6b13r28897bf71fc5e11b@mail.gmail.com>
In-Reply-To: <7vbpjlycqc.fsf@alter.siamese.dyndns.org>

2009/11/1 Junio C Hamano <gitster@pobox.com>:

Show 11 quoted lines

> Erick Mattos <erick.mattos@gmail.com> writes:
>
>>>    % git commit --claim --author='Erick Mattos <eric@mattos>' -C HEAD
>>>
>>> Should you detect an error?  Does your code do so?  Do you have a test
>>> that catches this error?
>>
>> It works as intended.  Both together.
>
> That does not make any sense.  If you are saying this is yours and it is
> his at the same time, there can be no sane way to work "as intended", no?.

I am adding a new option not changing the option --author already in git. So it does work together.

Show 11 quoted lines

>>>> +     git commit -c HEAD <<EOF
>>>> +     "Changed"
>>>> +     EOF &&
>>>
>>> What editor is reading this "Changed"?
>>
>> Nobody cares...  Just a text to change the file.
>
> I actually care.  Who uses that Changed string, and where does it end up
> with?  At the end of the log message?  At the beginning?  What "file"?
>

I didn't get it. -c option does not accept -m option and starts an editor to change the message. The text "Changed is just a forced message. I can not use an editor in interactive mode in a script... What I am losing here??