git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] grep: simple test for operation in a bare repository

From
Junio C Hamano <gitster@pobox.com>
Date
Feb 6, 2010, 18:47 UTC
Message-ID
<7v7hqqyzem.fsf@alter.siamese.dyndns.org>
In-Reply-To
<4B6D37D7.6010505@lsrfire.ath.cx>
René Scharfe <rene.scharfe@lsrfire.ath.cx> writes:
Show 11 quoted lines
> This patch converts the setenv() calls in path.c and setup.c.  After
> the call, git grep with a pager works again in bare repos.
>
> It leaves the setenv(GIT_DIR_ENVIRONMENT, ...) calls in git.c alone, as
> they respond to command line switches that emulate the effect of setting
> the environment variable directly.
>
> The remaining site in environment.c is in set_git_dir() and is left
> alone, too, of course.  Finally, builtin-init-db.c is left changed
> because the repo is still being carefully constructed when the
> environment variable is set.

Thanks for a thorough analysis. The patch looks correct and I am very tempted to put it into 1.7.0, though I'd stop at queuing it to 'next'.

Previous: René ScharfeNext: Junio C Hamano
Message 6 of 7 in “grep: simple test for operation in a bare repository”
  1. grep: simple test for operation in a bare repositoryRené Scharfe, Feb 3, 2010
  2. René ScharfeFeb 3, 2010
  3. René ScharfeFeb 5, 2010
  4. Nguyen Thai Ngoc DuyFeb 5, 2010
  5. René ScharfeFeb 6, 2010
  6. Junio C HamanoFeb 6, 2010
  7. Junio C HamanoFeb 5, 2010

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.