Re: [PATCH] grep: simple test for operation in a bare repository
- From
René Scharfe <rene.scharfe@lsrfire.ath.cx>
- Date
- Feb 6, 2010, 09:35 UTC
- Message-ID
- <4B6D37D7.6010505@lsrfire.ath.cx>
- In-Reply-To
- <fcaeb9bf1002041840l4d8e8ac9k3ad5e9e8761aa1b@mail.gmail.com>
Am 05.02.2010 03:40, schrieb Nguyen Thai Ngoc Duy:
Show 12 quoted lines
> setup_pager() calls git_config(), which indirectly calls get_git_dir() > and sets git_dir in stone. Changing GIT_DIR environment variable alone > won't work, as you have seen. > > When RUN_SETUP is set, setup_git_directory() would be called before > setup_pager() can kick in, so everything is properly set. > >> There are five more sites in git.c, path.c and setup.c where $GIT_DIR >> is set directly with setenv(). I wonder if they should better call >> set_git_dir() instead, too. > > Yes, they should.
This patch converts the setenv() calls in path.c and setup.c. After the call, git grep with a pager works again in bare repos.
It leaves the setenv(GIT_DIR_ENVIRONMENT, ...) calls in git.c alone, as they respond to command line switches that emulate the effect of setting the environment variable directly.
The remaining site in environment.c is in set_git_dir() and is left alone, too, of course. Finally, builtin-init-db.c is left changed because the repo is still being carefully constructed when the environment variable is set.
This fixes git shortlog when run inside a git directory, which had been broken by abe549e1.
Signed-off-by: Rene Scharfe <rene.scharfe@lsrfire.ath.cx> --- Since it's doesn't fix a regression (abe549e1 was committed in March 2008), this patch doesn't have to go in at this point in the release cycle. And perhaps it's even superseded by the more general fix Duy is working on?
path.c | 2 +- setup.c | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/path.c b/path.c index 79aa104..0005df3 100644 --- a/path.c +++ b/path.c @@ -336,7 +336,7 @@ char *enter_repo(char *path, int strict) if (access("objects", X_OK) == 0 && access("refs", X_OK) == 0 && validate_headref("HEAD") == 0) { - setenv(GIT_DIR_ENVIRONMENT, ".", 1); + set_git_dir("."); check_repository_format(); return path; } diff --git a/setup.c b/setup.c index 710e2f3..b38cbee 100644 --- a/setup.c +++ b/setup.c @@ -404,9 +404,9 @@ const char *setup_git_directory_gently(int *nongit_ok) inside_work_tree = 0; if (offset != len) { cwd[offset] = '\0'; - setenv(GIT_DIR_ENVIRONMENT, cwd, 1); + set_git_dir(cwd); } else - setenv(GIT_DIR_ENVIRONMENT, ".", 1); + set_git_dir("."); check_repository_format_gently(nongit_ok); return NULL; }