Re: [PATCH] rebase -i: use 'read -r' to avoid backslash acting as an escape character
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Jul 8, 2010, 00:29 UTC
- Message-ID
- <7v7hl6stna.fsf@alter.siamese.dyndns.org>
- In-Reply-To
- <20100707094620.GC31048@genesis.frugalware.org>
Miklos Vajna <vmiklos@frugalware.org> writes:
Show 10 quoted lines
> On Wed, Jul 07, 2010 at 11:22:29AM +0200, Santi Béjar <santi@agolina.net> wrote: >> No. This one: >> >> http://article.gmane.org/gmane.comp.version-control.git/150328 >> >> :-) > > Heh, then sorry for the noise. I noticed the problem on 2th, added the > "I should fix this" to my TODO, then made the patch yesterday. I forgot > to check the list archive again before sending the patch. ;-)
Thanks anyway. It may have been a bit of duplicated effort, but served as a sanity check as well.
Our patches do seem to fix the reading side of the issue, but I am not sure if the writing side needs further fix. If I recall, the script had liberal use of "echo $var"; some implementations of echo interprets backslash sequence without being asked with an explicit "-e".