Re: [RFC] war on echo in scripts

From

Jonathan Nieder <jrnieder@gmail.com>

Date

Jul 9, 2010, 02:46 UTC

Message-ID

<20100709024633.GA13739@dert.cs.uchicago.edu>

In-Reply-To

<m2k4p58tum.fsf@igel.home>

Andreas Schwab wrote:

> Jonathan Nieder <jrnieder@gmail.com> writes:

>>  die() {
>> -	echo >&2 "$@"
>> +	printf >&2 '%s\n' "$@"
>
> You probably want to use "$*" here, though it wouldn't matter for the
> uses of die in this file.

Hmm, maybe something like this would be easier.

Signed-off-by: Jonathan Nieder <jrnieder@gmail.com>
---

diff --git a/git-sh-setup.sh b/git-sh-setup.sh
index 6131670..b38b40b 100644
--- a/git-sh-setup.sh
+++ b/git-sh-setup.sh
@@ -39,6 +39,10 @@ git_broken_path_fix () {
 
 # @@BROKEN_PATH_FIX@@
 
+echo() {
+	printf '%s\n' "$*"
+}
+
 die() {
 	echo >&2 "$@"
 	exit 1