Re: [PATCH] Corrected return values in prep_for_email;

From: Junio C Hamano <gitster@pobox.com>
Date: Dec 9, 2010, 17:38 UTC
Message-ID: <7v7hfihmmo.fsf@alter.siamese.dyndns.org>
In-Reply-To: <004301cb97ba$90772630$b1657290$@me.uk>

"Alan Raison" <alan@theraisons.me.uk> writes:

Show 5 quoted lines

> Function was returning 0 for failure and 1 for success which was breaking
> the logic in the main loop.
>
> Corrected to return 0 for success, 1 for failure.  Function now also returns
> in all cases, rather than exiting.

Thanks, will apply.

> Acked-By: Kevin P. Fleming <kpfleming@digium.com>
> Signed-Off-By: Alan Raison <alan@theraisons.me.uk>

Just for reference---the order of events is that you signed-off first and then Kevin acked the result, so the above is backwards.

Also your patch was linewrapped, but I can fix it up---no need to resend, but please tell your MUA not to corrupt patches next time.