[PATCH] Corrected return values in prep_for_email;
- From
Alan Raison <alan@theraisons.me.uk>
- Date
- Dec 9, 2010, 16:00 UTC
- Message-ID
- <004301cb97ba$90772630$b1657290$@me.uk>
- In-Reply-To
- <4CFE8E97.4020508@digium.com>
Function was returning 0 for failure and 1 for success which was breaking the logic in the main loop.
Corrected to return 0 for success, 1 for failure. Function now also returns in all cases, rather than exiting.
Acked-By: Kevin P. Fleming <kpfleming@digium.com> Signed-Off-By: Alan Raison <alan@theraisons.me.uk> --- contrib/hooks/post-receive-email | 8 ++++---- 1 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/contrib/hooks/post-receive-email b/contrib/hooks/post-receive-email index 85724bf..f99ea95 100755 --- a/contrib/hooks/post-receive-email +++ b/contrib/hooks/post-receive-email @@ -144,13 +144,13 @@ prep_for_email() short_refname=${refname##refs/remotes/} echo >&2 "*** Push-update of tracking branch, $refname" echo >&2 "*** - no email generated." - exit 0 + return 1 ;; *) # Anything else (is there anything else?) echo >&2 "*** Unknown type of update to $refname ($rev_type)" echo >&2 "*** - no email generated" - return 0 + return 1 ;; esac @@ -166,10 +166,10 @@ prep_for_email() esac echo >&2 "*** $config_name is not set so no email will be sent" echo >&2 "*** for $refname update $oldrev->$newrev" - return 0 + return 1 fi - return 1 + return 0 } #
-- 1.7.3.1.msysgit.0