Re: [PATCH 7/7] archive: provide builtin .tar.gz filter

From

Junio C Hamano <gitster@pobox.com>

Date

Jun 15, 2011, 23:57 UTC

Message-ID

<7v7h8mir5u.fsf@alter.siamese.dyndns.org>

In-Reply-To

<7vboxyir8y.fsf@alter.siamese.dyndns.org>

Junio C Hamano <gitster@pobox.com> writes:

> Jeff King <peff@peff.net> writes:
>
>> +test_expect_success 'git archive --format=tgz' '
>> +	git archive --format=tgz HEAD >j.tgz
>> +'
>> +
>> +test_expect_success 'infer tgz from .tgz filename' '
>> +	git archive --output=j1.tgz HEAD &&
>> +	test_cmp j.tgz j1.tgz
>> +'
>
> I suspect this would get intermittent failures for the same reason as
> 0c8c385 (gitweb: supply '-n' to gzip for identical output, 2011-04-26)

To be squashed into 7/7, I guess...

 archive-tar-filter.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/archive-tar-filter.c b/archive-tar-filter.c
index de8719a..d6e4e32 100644
--- a/archive-tar-filter.c
+++ b/archive-tar-filter.c
@@ -131,7 +131,7 @@ static void load_builtin_filters(void)
 	struct tar_filter *tf;
 
 	tf = tar_filter_new("tgz", strlen("tgz"));
-	tf->command = xstrdup("gzip");
+	tf->command = xstrdup("gzip -n");
 	string_list_append(&tf->extensions, "tgz");
 	string_list_append(&tf->extensions, "tar.gz");
 	tf->use_compression = 1;