git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: what are the chances of a 'pre-upload' hook?

From
Junio C Hamano <gitster@pobox.com>
Date
Nov 26, 2011, 22:34 UTC
Message-ID
<7v7h2my0ky.fsf@alter.siamese.dyndns.org>
In-Reply-To
<20111125144007.GA4047@sigill.intra.peff.net>
Jeff King <peff@peff.net> writes:
> The easiest way would be something like a "trust remote hooks"
> environment variable, off by default. Admins in situation (2) could set
> it for their git-daemon (or webserver, or whatever, or
> gitolite-over-ssh), once they decided it was safe.

Alice and Bob may work on the same project, and they may want to trust each other as participants of that project, but that does not mean Alice wants to give Bob a blanket access to places she owns that are not shared with the project members (e.g. her $HOME directory), so I am afraid "trust remote hooks" is not a workable solution for the casual sharing on sites that do not fall into either of your two classes.

The real reason why the upload-hook violates the expectation of the users is because it would run as the user who fetches, I think. If it ran with the intersection of capabilities of the owner of the repository and the user who is fetching, I suspect that we would not have to worry about it.

What would happen if we allowed some hooks to run only when the process is running under a group-id that can write into the repository? When Alice fetches from the repository, it would still run as her and would have an access to her $HOME, so this won't really work yet, but I am wondering if there is a workable alternative along this line.

Previous: Jeff KingNext: Jeff King
Message 8 of 23 in “what are the chances of a 'pre-upload' hook?”
  1. Sitaram ChamartyNov 25, 2011
  2. Martin FickNov 25, 2011
  3. Martin FickNov 25, 2011
  4. Sitaram ChamartyNov 25, 2011
  5. Andreas EricssonNov 25, 2011
  6. Sitaram ChamartyNov 25, 2011
  7. Jeff KingNov 25, 2011
  8. Junio C HamanoNov 26, 2011
  9. Jeff KingNov 26, 2011
  10. Junio C HamanoNov 26, 2011
  11. Jeff KingNov 26, 2011
  12. Junio C HamanoNov 27, 2011
  13. Jeff KingNov 26, 2011
  14. Jeff KingNov 27, 2011
  15. Junio C HamanoNov 27, 2011
  16. Sitaram ChamartyNov 27, 2011
  17. Junio C HamanoNov 28, 2011
  18. Jeff KingNov 28, 2011
  19. Sitaram ChamartyNov 28, 2011
  20. Sitaram ChamartyNov 28, 2011
  21. Jeff KingNov 28, 2011
  22. Jeff KingNov 28, 2011
  23. Jeff KingNov 28, 2011

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.