Re: FYI: git-am allows creation of empty commits.

From: Junio C Hamano <junkio@cox.net>
Date: Feb 25, 2006, 06:04 UTC
Message-ID: <7v64n47z4f.fsf@assigned-by-dhcp.cox.net>
In-Reply-To: <20060224131922.GA19401@localdomain>

Eric Wong <normalperson@yhbt.net> writes:

Show 12 quoted lines

>> I think 99.9% of the time it is a mistake if a single-parented
>> commit has the same tree as its parent commit has, so having a
>> check in commit-tree may not be a bad idea.
>
> This would break importers, more than 0.1% I think...  Arch
> definitely allows empty commits for getting log messages in.
> SVN forbids them from their POV, but they also have things
> that we can't see when we import (properties like: mime,
> externals, eol-style) causing us to write the same tree twice.
> Not sure about CVS...
>
> Maybe a flag such as --force could be added.

Good point perhaps. Maybe an explicit --no-empty should ask for it, and git-am should use it. As to git-commit I am unsure.

In the meantime I'd drop the patch.