Re: FYI: git-am allows creation of empty commits.

From: Eric Wong <normalperson@yhbt.net>
Date: Feb 24, 2006, 13:19 UTC
Message-ID: <20060224131922.GA19401@localdomain>
In-Reply-To: <7vy8019d44.fsf@assigned-by-dhcp.cox.net>

Junio C Hamano <junkio@cox.net> wrote:

Show 12 quoted lines

> ebiederm@xmission.com (Eric W. Biederman) writes:
> 
> > Is this something that we always want to test for in the porcelain
> > or do we want to move a check into git-commit-tree?
> >
> > For getting a reasonable error message where you have the test
> > seems to be the only sane place, but having the check deeper
> > down would be more likely to catch this kind of thing.
> 
> I think 99.9% of the time it is a mistake if a single-parented
> commit has the same tree as its parent commit has, so having a
> check in commit-tree may not be a bad idea.

This would break importers, more than 0.1% I think... Arch definitely allows empty commits for getting log messages in. SVN forbids them from their POV, but they also have things that we can't see when we import (properties like: mime, externals, eol-style) causing us to write the same tree twice. Not sure about CVS...

Maybe a flag such as --force could be added.

-- 
Eric Wong