Re: [PATCH] mailinfo: better parse email adresses containg parentheses

From: Junio C Hamano <gitster@pobox.com>
Date: Jul 22, 2008, 03:16 UTC
Message-ID: <7v63qyr4kk.fsf@gitster.siamese.dyndns.org>
In-Reply-To: <1216647269-12287-1-git-send-email-book@cpan.org>

"Philippe Bruhat (BooK)" <book@cpan.org> writes:

Show 11 quoted lines

>     When using git-rebase, author fields containing a ')' at the last
>     position had the close-parens character incorrectly removed
>     because the From: parser incorrectly matched it as
>
>         user@host (User Name)
>
>     (removing parentheses), instead of
>
>         User Name (me) <user@host>
>
> Signed-off-by: Philippe Bruhat (BooK) <book@cpan.org>

Hmm, tests?

By the way, that second form parses like this:

	mailbox =
        name-addr =
        display-name angle-addr = "User Name (me) <user@host>"

        display-name =
        phrase = "User Name"
        
        angle-addr = CFWS "<" addr-spec ">" = "(me) <user@host>"

So strictly speaking, shouldn't we be stripping the whole (me) as garbage? It is not even part of the display-name but is a whitespace equivalent comment.