Re: [PATCH] mailinfo: better parse email adresses containg parentheses

From: Philippe Bruhat (BooK) <book@cpan.org>
Date: Jul 22, 2008, 10:24 UTC
Message-ID: <20080722102439.GB7792@plop>
In-Reply-To: <7v63qyr4kk.fsf@gitster.siamese.dyndns.org>

On Mon, Jul 21, 2008 at 08:16:43PM -0700, Junio C Hamano wrote:

Show 19 quoted lines

> >
> > Signed-off-by: Philippe Bruhat (BooK) <book@cpan.org>
> 
> Hmm, tests?
> 
> By the way, that second form parses like this:
> 
> 	mailbox =
>         name-addr =
>         display-name angle-addr = "User Name (me) <user@host>"
> 
>         display-name =
>         phrase = "User Name"
>         
>         angle-addr = CFWS "<" addr-spec ">" = "(me) <user@host>"
> 
> So strictly speaking, shouldn't we be stripping the whole (me) as garbage?
> It is not even part of the display-name but is a whitespace equivalent
> comment.

Well, I use this:

    "Philippe Bruhat (BooK)" <book@cpan.org>

as my From: line, and I would like to be able to use it so in git.

As git knows the difference between user name and user email, it should be able to keep the information separate all the way.

Which makes me think that since it seems that rebase goes through a patch-file step, the problem with my username may actually lie with creating the patch file (no quotes around a user name containing parens) rather than with parsing the patch From: line.

-- 
 Philippe Bruhat (BooK)

 Everyone's life seems easier from the outside.
                                    (Moral from Groo The Wanderer #45 (Epic))