git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] Introduce receive.denyDeletes

From
Junio C Hamano <gitster@pobox.com>
Date
Oct 31, 2008, 08:04 UTC
Message-ID
<7v63n99omx.fsf@gitster.siamese.dyndns.org>
In-Reply-To
<20081030194503.2f9ece1a@perceptron>
"Jan Krüger" <jk@jk.gs> writes:
> Can I then delete the branch afterwards without lots of juggling (in
> case the test fails due to a random other reason that the branch
> accidentally getting deleted by receive-pack)? I'd expect I'd have to
> save the exit code to a temporary variable and that's just as ugly.

Although I agree that your attempt to allow the test continue even when this test fails is a very good practice, I personally do not find the alternative you mention ugly at all. I actually find that "return 1" uglier because it feels like it knows too much about how test_expect_success is implemented.

Previous: Jan KrügerNext: Shawn O. Pearce
Message 4 of 8 in “Introduce receive.denyDeletes”
  1. Introduce receive.denyDeletesJan Krüger, Oct 30, 2008
  2. Shawn O. PearceOct 30, 2008
  3. Jan KrügerOct 30, 2008
  4. Junio C HamanoOct 31, 2008
  5. Shawn O. PearceOct 31, 2008
  6. Introduce receive.denyDeletesJan Krüger, Nov 1, 2008
  7. Shawn O. PearceNov 1, 2008
  8. Johannes SchindelinOct 31, 2008

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.