From: Junio C Hamano <gitster@pobox.com>
Date: Fri, 31 Oct 2008 08:04:22 GMT
Subject: Re: [PATCH] Introduce receive.denyDeletes
Message-ID: <7v63n99omx.fsf@gitster.siamese.dyndns.org>
In-Reply-To: <20081030194503.2f9ece1a@perceptron>

"Jan Krüger" <jk@jk.gs> writes:

> Can I then delete the branch afterwards without lots of juggling (in
> case the test fails due to a random other reason that the branch
> accidentally getting deleted by receive-pack)? I'd expect I'd have to
> save the exit code to a temporary variable and that's just as ugly.

Although I agree that your attempt to allow the test continue even when
this test fails is a very good practice, I personally do not find the
alternative you mention ugly at all.  I actually find that "return 1"
uglier because it feels like it knows too much about how
test_expect_success is implemented.