Re: [PATCH] autodetect number of CPUs by default when using threads
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Dec 11, 2008, 22:25 UTC
- Message-ID
- <7v63lqcptn.fsf@gitster.siamese.dyndns.org>
- In-Reply-To
- <alpine.LFD.2.00.0812111524370.14328@xanadu.home>
Nicolas Pitre <nico@cam.org> writes:
Show 7 quoted lines
> I've spent quite a while wondering why repacking in one repo was faster > than repacking in a clone of that repo on the same machine. So let's > display how many threads are actually used. > > We have comprehensive test in Makefile to determine if threads are > available, just to not use them by default. I think that code has > proven itself for long enough now not to let people benefit from it.
Hmm, it does appear that distros compile with THREADED_DELTA_SEARCH turned on (I only checked Fedora and Debian), and I tend to agree with "long enough" but "proven itself" feels bit too strong a statement.
I think defaulting to autodetect is a good change. I do not like to add new output to stderr deep in -rc, though.
Can we park this in 'next' and move it to 'master' after 1.6.1?