git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] pack-objects: don't use too many threads with few objects

From
Jeff King <peff@peff.net>
Date
Dec 16, 2008, 03:20 UTC
Message-ID
<20081216032016.GA4247@coredump.intra.peff.net>
In-Reply-To
<7vy6ygudhb.fsf@gitster.siamese.dyndns.org>
On Mon, Dec 15, 2008 at 05:15:44PM -0800, Junio C Hamano wrote:
> Perhaps the two runs are seeing different number of CPUs (hence threads)
> available?  That would then change the distribution of the work itself
> (i.e. what slice of obj-list goes as a single chunk to be processed) and
> would affect the outcome.

I am seeing the same failure as Mike on one of my boxen. Each run sees the same number of threads (4 in my case).

> Does the second test this patch adds fail?

With your patch, the added "both should match" test fails. So it seems to be about doing a second run at all, not the difference in index versions.

-Peff
Previous: Junio C HamanoNext: Nicolas Pitre
Message 10 of 11 in “autodetect number of CPUs by default when using threads”
  1. autodetect number of CPUs by default when using threadsNicolas Pitre, Dec 11, 2008
  2. Junio C HamanoDec 11, 2008
  3. Nicolas PitreDec 12, 2008
  4. Jeff KingDec 13, 2008
  5. Nicolas PitreDec 13, 2008
  6. pack-objects: don't use too many threads with few objectsNicolas Pitre, Dec 13, 2008
  7. Jeff KingDec 14, 2008
  8. Mike RalphsonDec 15, 2008
  9. Junio C HamanoDec 16, 2008
  10. Jeff KingDec 16, 2008
  11. Nicolas PitreDec 16, 2008

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.