git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: Sha1 lookup and GIT_USE_LOOKUP

From
Junio C Hamano <gitster@pobox.com>
Date
Jun 8, 2011, 18:55 UTC
Message-ID
<7v62og2lw1.fsf@alter.siamese.dyndns.org>
In-Reply-To
<BANLkTintTECbO5X3VMvzHdGgyKmLKe65YE=0mX6Ahj5wutCJ0Q@mail.gmail.com>
Marc Pegon <pegon.marc@gmail.com> writes:
> Since this environment variable is not set by default, git will always
> use a simple binary search, won't it ?
Yes.
> Also, when searching for a sha1 given a sha1 prefix, among packed
> objects, find_short_packed_object also does a simple binary search.
> Wouldn't it be simpler to just use the sha1_entry_pos method ?
Unknown ;-).

The environment variable is there exactly for people like you who are interested in finding out which one yields better performance by benchmarking. Once we can get a convincing result, we can either deprecate the more involved sha1_entry_pos() if it turns out to be not worth it, or we can always use it if it turns out to be significantly better.

Thanks.
Previous: Marc PegonNext: Marc Pegon
Message 2 of 4 in “Sha1 lookup and GIT_USE_LOOKUP”
  1. Marc PegonJun 8, 2011
  2. Junio C HamanoJun 8, 2011
  3. Marc PegonJun 9, 2011
  4. Michael SchubertJun 9, 2011

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.