From: Junio C Hamano Date: Wed, 08 Jun 2011 18:55:42 GMT Subject: Re: Sha1 lookup and GIT_USE_LOOKUP Message-ID: <7v62og2lw1.fsf@alter.siamese.dyndns.org> In-Reply-To: Marc Pegon writes: > Since this environment variable is not set by default, git will always > use a simple binary search, won't it ? Yes. > Also, when searching for a sha1 given a sha1 prefix, among packed > objects, find_short_packed_object also does a simple binary search. > Wouldn't it be simpler to just use the sha1_entry_pos method ? Unknown ;-). The environment variable is there exactly for people like you who are interested in finding out which one yields better performance by benchmarking. Once we can get a convincing result, we can either deprecate the more involved sha1_entry_pos() if it turns out to be not worth it, or we can always use it if it turns out to be significantly better. Thanks.