Re: [PATCH 2/5] add object-cache infrastructure
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Jul 12, 2011, 18:41 UTC
- Message-ID
- <7v62n78hpk.fsf@alter.siamese.dyndns.org>
- In-Reply-To
- <20110712175739.GA17031@sigill.intra.peff.net>
Jeff King <peff@peff.net> writes:
Show 5 quoted lines
> 2. The disk store uses a binary search over a sorted list of sha1s. > Generalizing this to "a sequence of bytes" would not be hard. But > we currently have the option of using the uniform distribution of > sha1 to make better guesses about our "middle" (see the comments in > sha1-lookup.c). That assumption does not hold over arbitrary bytes.
A side note. I notice that the "comment" you refer to appears twice in the file, and the sha1_pos() function that comes earlier in the file does not protect itself from overshoot penalty like the sha1_entry_pos() function does.
Perhaps we should think about unifying them somehow.