git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] help: correct behavior for is_executable on Windows

From
Junio C Hamano <gitster@pobox.com>
Date
Aug 15, 2012, 19:39 UTC
Message-ID
<7v628k54hy.fsf@alter.siamese.dyndns.org>
In-Reply-To
<7v7gt06nyk.fsf@alter.siamese.dyndns.org>
Junio C Hamano <gitster@pobox.com> writes:
Show 9 quoted lines
>> diff --git a/help.c b/help.c
>> ...
>> +
>
> Yuck.
>
> Why should we need even a single line of the implementation of a
> function that tells if a given pathname contains an executable
> command, which we know is platform specific?  
Sorry; sent without sufficient proofreading.

Obviously we need such an implementation (per platform) somewhere in the system.

What I meant to ask was "Why should we need a function whose implementation has to be platform-specific in this help.c file". The last part of the sentence was missing.

Previous: Junio C HamanoNext: Heiko Voigt
Message 7 of 11 in “help: correct behavior for is_executable on Windows”
  1. help: correct behavior for is_executable on WindowsHeiko Voigt, Aug 11, 2012
  2. Junio C HamanoAug 12, 2012
  3. Heiko VoigtAug 13, 2012
  4. Junio C HamanoAug 13, 2012
  5. Heiko VoigtAug 15, 2012
  6. Junio C HamanoAug 15, 2012
  7. Junio C HamanoAug 15, 2012
  8. Heiko VoigtAug 15, 2012
  9. Junio C HamanoAug 15, 2012
  10. Junio C HamanoAug 16, 2012
  11. Heiko VoigtAug 16, 2012

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.