From: Junio C Hamano <gitster@pobox.com>
Date: Wed, 15 Aug 2012 19:39:37 GMT
Subject: Re: [PATCH] help: correct behavior for is_executable on Windows
Message-ID: <7v628k54hy.fsf@alter.siamese.dyndns.org>
In-Reply-To: <7v7gt06nyk.fsf@alter.siamese.dyndns.org>

Junio C Hamano <gitster@pobox.com> writes:

>> diff --git a/help.c b/help.c
>> ...
>> +
>
> Yuck.
>
> Why should we need even a single line of the implementation of a
> function that tells if a given pathname contains an executable
> command, which we know is platform specific?  

Sorry; sent without sufficient proofreading.  

Obviously we need such an implementation (per platform) somewhere in
the system.

What I meant to ask was "Why should we need a function whose
implementation has to be platform-specific in this help.c file".
The last part of the sentence was missing.