git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 1/2] rev-parse: add --filename-prefix option

From
Junio C Hamano <gitster@pobox.com>
Date
Apr 8, 2013, 18:11 UTC
Message-ID
<7v61zwyjs8.fsf@alter.siamese.dyndns.org>
In-Reply-To
<20130408173604.GP2222@serenity.lan>
John Keeping <john@keeping.me.uk> writes:
Show 20 quoted lines
> On Mon, Apr 08, 2013 at 08:07:32AM -0700, Junio C Hamano wrote:
>> John Keeping <john@keeping.me.uk> writes:
>> 
>> > Yes (ish), the intended usage is something like this:
>> >
>> >     prefix=$(git rev-parse --show-prefix)
>> >     cd_to_toplevel
>> >     ... parse options here ...
>> >     # Convert remaining arguments (filenames) into top-level paths:
>> >     eval "set $(git rev-parse --prefix "$prefix" --sq -- "$@")"
>> >
>> > The "ish" is that my current implementation introduced a new variable
>> > instead of simply resetting the existing "prefix" variable, which I
>> > assume is what you mean.
>> 
>> This is very sensible.
>
> Which bit specifically?  I assume you agree with the intended usage, but
> do you also mean that resetting the prefix returned from
> setup_git_directory is the right way to approach this?

My gut feeling says yes, but you can persuade me easily why it is a bad idea if you have an example of why it would not work well.

Previous: John KeepingNext: John Keeping
Message 7 of 39 in “submodule: drop the top-level requirement”
  1. 0/2 submodule: drop the top-level requirementJohn Keeping, Apr 7, 2013
  2. 1/2 rev-parse: add --filename-prefix optionJohn Keeping, Apr 7, 2013
  3. Jonathan NiederApr 7, 2013
  4. John KeepingApr 8, 2013
  5. Junio C HamanoApr 8, 2013
  6. John KeepingApr 8, 2013
  7. Junio C HamanoApr 8, 2013
  8. 2/2 submodule: drop the top-level requirementJohn Keeping, Apr 7, 2013
  9. Jens LehmannApr 7, 2013
  10. 0/2 submodule: drop the top-level requirementJohn Keeping, Apr 9, 2013
  11. 1/2 rev-parse: add --filename-prefix optionJohn Keeping, Apr 9, 2013
  12. Junio C HamanoApr 9, 2013
  13. John KeepingApr 9, 2013
  14. Junio C HamanoApr 9, 2013
  15. Ramkumar RamachandraApr 18, 2013
  16. John KeepingApr 18, 2013
  17. 2/2 submodule: drop the top-level requirementJohn Keeping, Apr 9, 2013
  18. Junio C HamanoApr 9, 2013
  19. John KeepingApr 9, 2013
  20. Ramkumar RamachandraApr 18, 2013
  21. John KeepingApr 18, 2013
  22. 0/2 submodule: drop the top-level requirementJohn Keeping, Apr 18, 2013
  23. 1/2 rev-parse: add --prefix optionJohn Keeping, Apr 18, 2013
  24. Ramkumar RamachandraApr 19, 2013
  25. John KeepingApr 19, 2013
  26. Ramkumar RamachandraApr 19, 2013
  27. John KeepingApr 19, 2013
  28. Ramkumar RamachandraApr 19, 2013
  29. 2/2 submodule: drop the top-level requirementJohn Keeping, Apr 18, 2013
  30. Junio C HamanoApr 18, 2013
  31. John KeepingApr 19, 2013
  32. Junio C HamanoApr 19, 2013
  33. Johannes SixtApr 19, 2013
  34. Junio C HamanoApr 19, 2013
  35. submodule: fix quoting in relative_path()John Keeping, Apr 24, 2013
  36. Junio C HamanoApr 24, 2013
  37. John KeepingApr 24, 2013
  38. Johannes SixtApr 24, 2013
  39. Eric SunshineApr 18, 2013

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.