Re: [PATCH 1/2] rev-parse: add --filename-prefix option
- From
John Keeping <john@keeping.me.uk>
- Date
- Apr 8, 2013, 17:36 UTC
- Message-ID
- <20130408173604.GP2222@serenity.lan>
- In-Reply-To
- <7vmwt9ysaz.fsf@alter.siamese.dyndns.org>
On Mon, Apr 08, 2013 at 08:07:32AM -0700, Junio C Hamano wrote:
Show 15 quoted lines
> John Keeping <john@keeping.me.uk> writes: > > > Yes (ish), the intended usage is something like this: > > > > prefix=$(git rev-parse --show-prefix) > > cd_to_toplevel > > ... parse options here ... > > # Convert remaining arguments (filenames) into top-level paths: > > eval "set $(git rev-parse --prefix "$prefix" --sq -- "$@")" > > > > The "ish" is that my current implementation introduced a new variable > > instead of simply resetting the existing "prefix" variable, which I > > assume is what you mean. > > This is very sensible.
Which bit specifically? I assume you agree with the intended usage, but do you also mean that resetting the prefix returned from setup_git_directory is the right way to approach this?