Re: [PATCH 1/3] git-format-patch: Make the second and subsequent mails replies to the first

From: Junio C Hamano <junkio@cox.net>
Date: Jul 14, 2006, 18:23 UTC
Message-ID: <7v4pxkoxjp.fsf@assigned-by-dhcp.cox.net>
In-Reply-To: <1152897407.5177.8.camel@josh-work.beaverton.ibm.com>

Josh Triplett <josht@us.ibm.com> writes:

Show 7 quoted lines

>> While I understand what you said about imap-send, I really would
>> feel better if this was optional.  Do not change the default
>> output format, please.
>
> So rather than the --no-thread option provided in the second patch of
> this series, you'd prefer a --thread option to enable setting the
> In-Reply-To/References headers?

Eh, that's not what I meant.

I do not mind the code you added to log-tree.c and revision.h, and honestly I do not care which of threading or non-threading mode is the default, although I think your explanation that it parallels what send-email does makes a lot of sense.

But I do mind that the code added by the first patch to cmd_format_patch runs by default, and worse yet, there is no option turn it off. Setting message_id and ref_message_id in rev_info struct should be something the end user should ask for explicitly by invoking the command with an option, perhaps --with-message-id, which you probably would also want to turn on when any of --no-thread, --thread or --initial-reply-to options are given. -