Re: [PATCH] Provide better feedback for the untracked only case in status output

From: Junio C Hamano <junkio@cox.net>
Date: Jan 10, 2007, 07:39 UTC
Message-ID: <7v4pqzfhzd.fsf@assigned-by-dhcp.cox.net>
In-Reply-To: <17828.37642.473000.296809@lapjr.intranet.kiel.bmiag.de>

Juergen Ruehle <j.ruehle@bmiag.de> writes:

> Juergen Ruehle writes:
>  > [Corrupted patch deleted]
>
> Will try again when I know what happened.

While you are at it, let me point out one thing that has been annoying me for a while.

This is an example e-mail I have been getting from you (the below is before decoding MIME):

  From: Juergen Ruehle <j.ruehle@bmiag.de>
  Subject: [PATCH] Provide better feedback for the ...
  Date: Wed, 10 Jan 2007 08:08:12 +0100
  Message-ID: <1168412892113-git-send-email-j.ruehle@bmiag.de>
  Content-Type: text/plain; charset=UTF-8
  Content-Transfer-Encoding: quoted-printable
  Cc: git@vger.kernel.org,
          =?utf-8?q?J=C3=BCrgen_R=C3=BChle?= <j-r@online.de>
  X-Mailer: git-send-email 1.5.0.rc0.g525e

  From: =3D?utf-8?q?J=3DC3=3DBCrgen_R=3DC3=3DBChle?=3D <j-r@online.de>

  Since 98bf8a47c296f51ea9722fef4bb81dbfb70cd4bb status would claim that
  git-commit could be useful even if there are no changes except untracked =
  files.

  Since wt-status is already computing all the information go the whole way=
   and
  separately track the (non-)emptiness of all three sections, unify the cod=
  e, and
  provide separate messages for each case. This adds a new message for the
  untracked only case and adds an explanation for a completely empty workin=
  g
  directory during initial commit.

  This change is effectively reverting 98bf8a47c296f51ea9722fef4bb81dbfb70c=
  d4bb
  and replacing it by a cleaner version.

  Signed-off-by: J=C3=BCrgen R=C3=BChle <j-r@online.de>

Notice:

 * The message claims to be from git-send-email;

 * Content-Type and CTE are UTF-8 and QP (which is fine);

 * You have in-body From: line; this is not wrong per-se and I
   understand why you would want one (your e-mail From: line
   uses ASCII approximations "ue" and "ue" and you would want
   the resulting commit to spell your name correctly).

 * However, this in-body From: line is _doubly_ QP encoded (what
   you see above is your name, first RFC 2047 encoded and then
   QP encoded).  It shouldn't be.

So, my questions are:

 (1) is this what git-send-email generates and sends out by
     default?  If so that means it is a bug in that program that
     needs to be fixed.

 (2) if not, are you inserting the in-body From: by hand,
     perhaps cut & paste from format-patch output, before
     feeding git-send-email (which runs QP on it)?

If the latter, please do not paste the RFC 2047 quoted form. You can spell your name in raw UTF-8 on the in-body From: line just like you did on your Signed-off-by: line.