Re: [PATCH 1/2] Suggest use of "git add file1 file2" when there is nothing to commit.
- From
- Juergen Ruehle <j.ruehle@bmiag.de>
- Date
- Jan 6, 2007, 14:02 UTC
- Message-ID
- <17823.44049.943881.536532@lapjr.intranet.kiel.bmiag.de>
- In-Reply-To
- <1168029891.11130.18.camel@ibook.zvpunry.de>
Michael Loeffler writes:
> Hi,
>
> Am Freitag, den 15.12.2006, 21:53 -0500 schrieb Shawn O. Pearce:
> ...
> > @@ -292,7 +291,9 @@ void wt_status_print(struct wt_status *s)
> > if (s->verbose && !s->is_initial)
> > wt_status_print_verbose(s);
> > if (!s->commitable)
> > - printf("%s\n", s->amend ? "# No changes" : "nothing to commit");
> > + printf("%s (%s)\n",
> > + s->amend ? "# No changes" : "nothing to commit",
> > + use_add_msg);
> > }
> I don't like the new 'nothing to commit (use "git add ... message")'
> message. I use git status very often to see if there is something to
> commit, but now there is always this annoying "use git add ..." message.
> I just want to see on what the branch is and if there is something to
> commit.
>
> If there is something to commit I get the list of untracked or modified
> files with the use_add_msg and if I try to commit an empty tree as
> initial commit I get the message from git-commit.sh.I'd appreciate feedback on my series from the 2nd of January, especially part 3/4 (Subject: [PATCH 3/4] Improve "nothing to commit" part of status output). This is already part of next.
It removes the message if there really is nothing to commit and replaces it by a generic pointer to git add and git commit if there are pending changes in the working directory.