git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 3/5] introduce GIT_WORK_TREE environment variable

From
Junio C Hamano <junkio@cox.net>
Date
Mar 18, 2007, 20:28 UTC
Message-ID
<7v4poil2id.fsf@assigned-by-dhcp.cox.net>
In-Reply-To
<20070318202302.GA5191@moooo.ath.cx>
Matthias Lederhofer <matled@gmx.net> writes:
Show 11 quoted lines
> Matthias Lederhofer <matled@gmx.net> wrote:
>> Matthias Lederhofer <matled@gmx.net> wrote:
>> > +		inside_working_tree = !prefixcmp(cwd, worktree);
>> [..]
>> > +			inside_git_dir = !prefixcmp(cwd, gitdir);
>> 
>> This time a real bug: the parameters have to be the other way around.
>
> Sorry, it was right.  prefixcmp got me confused again when doing some
> testing and the result wasn't what I expected.  I'll go and copy&paste
> 100 times !prefixcmp(str, prefix) means "begins str with prefix?"

I do not mind replacing the whole set, but keeping track of these small "oops", "oh", "ah" are confusing to me.

Could you take a deep breath, review them yourself one more time, and resend, *after* making sure that you are confident with them enough to feel that you would not have to issue "oops", "sorry", "ah this is better" messages for a few days after sending them out, pretty please?

Previous: Matthias LederhoferNext: Matthias Lederhofer
Message 12 of 18 in “git-init: set core.workdir when GIT_WORK_DIR is specified”
  1. git-init: set core.workdir when GIT_WORK_DIR is specifiedMatthias Lederhofer, Mar 17, 2007
  2. Junio C HamanoMar 17, 2007
  3. Matthias LederhoferMar 17, 2007
  4. Matthias LederhoferMar 17, 2007
  5. 1/5 rev-parse: --is-bare-repository optionMatthias Lederhofer, Mar 17, 2007
  6. 2/5 test git-rev-parseMatthias Lederhofer, Mar 17, 2007
  7. test git-rev-parseMatthias Lederhofer, Mar 27, 2007
  8. 3/5 introduce GIT_WORK_TREE environment variableMatthias Lederhofer, Mar 17, 2007
  9. Matthias LederhoferMar 18, 2007
  10. Matthias LederhoferMar 18, 2007
  11. Matthias LederhoferMar 18, 2007
  12. Junio C HamanoMar 18, 2007
  13. 4/5 test GIT_WORK_TREEMatthias Lederhofer, Mar 17, 2007
  14. 5/5 git-init: set core.worktree when GIT_WORK_TREE is specifiedMatthias Lederhofer, Mar 17, 2007
  15. Junio C HamanoMar 18, 2007
  16. Matthias LederhoferMar 18, 2007
  17. Matthias LederhoferMar 18, 2007
  18. Johannes SchindelinMar 19, 2007

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.